First step toward the Excel-like editable-table the user asked for. Architecture decisions in this phase came from a focused research pass over Notion / Airtable / AG Grid / Handsontable / Glide / W3C ARIA APG; the design notes are in this commit's predecessor as a research synthesis. Five phases planned; this is phase 1 of 5 and ships the cell-selection + keyboard-navigation + per-cell editor mount-on-demand foundation. Edits in this phase live in a client- side draft buffer only; row-level save + ETag conflict UX is phase 3. Scope: - ARIA grid pattern verbatim (W3C WAI-ARIA APG): role=grid on the table, role=row on rows, role=gridcell on cells, roving tabindex (only one cell carries tabindex=0; arrows move it). This makes the grid one tab stop in the page tab order — the documented spreadsheet UX, and also the basis for screen-reader correctness. - Click selects a cell. Arrow keys move selection. Tab and Shift-Tab move with row-wrap. Home / End jump within row; Ctrl/Cmd+Home / End jump to grid corners. Enter, F2, double- click, or any printable character all enter edit mode. In edit mode: Enter commits and moves down (Excel convention), Tab commits and moves right (with row-wrap), Escape cancels and restores the prior value, blur commits. - Mount-on-demand cell editor: one <input> at a time is instantiated inside the selected cell. Survives 1000-row tables without the focus-ring churn an always-editable design would hit, and lets Phase 2 swap the input for schema-driven widgets (number / date / select / etc.) without restructuring. - Draft buffer at app.state.drafts keyed by row id (the row's re-edit URL — stable across sort and filter). When a cell commits with a value different from row.data, the draft entry is set; render reads from the draft via effectiveCellValue() so the visible cell content reflects unsaved edits. No-op edits (commit returns the original value) clear any pending draft. - Selection survives re-paints. Sort / filter / spec changes trigger a re-render; the editor's setSelected at end of paint() clamps to new bounds and rebinds tabindex. The user's cell doesn't disappear when they sort the column they're editing. - Numeric coercion fast-path: cells whose column declares format=number/integer coerce the input string to Number on commit. Phase 2 will generalize this to schema-driven coercion for date, boolean, enum, etc. UX consequence — single-click semantics change: The pre-existing row-click-navigates-to-form-edit behavior is gone. Single click now selects a cell (spreadsheet-native). The "open this row in the form editor" affordance moves to phase 2 (an explicit "Edit…" button or an icon column). The row-click- navigation tests in tests/tables.spec.js are replaced with seven new tests covering the editor lifecycle. What this phase does NOT do (and which phases own it): - Phase 2: schema-driven editor widgets (right input type per column). Server-side validation 422 → red-corner marks. Complex types (object, generic array, oneOf) get an "Edit…" button that opens the side-panel form-render mode the unified bundle already ships. - Phase 3: row-level save on row-blur via PUT + If-Match. Stale- row badge with "Use mine" / "Reload" on 412. Outbox carries the offline path transparently via the existing source.js layer. - Phase 4: copy/paste from Excel/Sheets via TSV parser, spill- from-anchor or fill-all into a selection range. - Phase 5: undo (linear command stack, Ctrl+Z, session-local) and multi-cell ops (range select, bulk delete, Ctrl+D / Ctrl+R fill). Tests (tests/tables.spec.js, all 15 pass): - clicking a cell selects it (replaces the old row-click-navigates test; verifies single-click does NOT navigate) - arrow keys move cell selection - Tab and Shift-Tab traverse cells with row-wrap - Enter enters edit mode; Enter commits and moves down (verifies draft is applied to visible cell + selection moves) - Escape cancels edit, restoring prior value (verifies no-op on draft buffer) - typing a printable char enters edit and replaces the value - double-click also enters edit mode - non-editable rows still get the readonly class (cosmetic guard for an existing convention; phase 3 will gate write submission) Files: - tables/js/editor.js (new) — selection + keyboard handling + edit-mode lifecycle + draft buffer. - tables/js/app.js — state.selected / state.editing / state.drafts fields. - tables/js/render.js — ARIA roles + editor.attachToCell wiring; cells render via editor.effectiveCellValue so drafts show. - tables/js/main.js — paint()-end editor.attachToTable + setSelected restore. - tables/css/table.css — selected-cell focus ring (outline, doesn't shift surrounding cells); cell-input bare-inside-cell styling. - tables/build.sh — editor.js in the concat list. - zddc/internal/handler/tables.html — regenerated bundle. Bundle size: 117 KB → 124 KB (+7 KB for editor.js + ARIA + draft machinery). Well within the budget the library survey identified (Tabulator would have been +100 KB; SlickGrid +34 KB; custom is +7 KB and we keep the no-third-party-deps invariant). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
97 lines
3.9 KiB
JavaScript
97 lines
3.9 KiB
JavaScript
(function (app) {
|
|
'use strict';
|
|
|
|
function renderHeader(theadEl, columns, sortState, filterMap, onHeaderClick, onFilterChange) {
|
|
const util = app.modules.util;
|
|
const filters = app.modules.filters;
|
|
const sort = app.modules.sort;
|
|
theadEl.innerHTML = '';
|
|
|
|
const titleRow = util.h('tr', { className: 'zddc-table__title-row' });
|
|
const filterRow = util.h('tr', { className: 'zddc-table__filter-row' });
|
|
|
|
for (let i = 0; i < columns.length; i++) {
|
|
const col = columns[i];
|
|
const indicator = sort.indicator(sortState, col.field);
|
|
const th = util.h('th', {
|
|
className: 'zddc-table__th',
|
|
'data-field': col.field,
|
|
style: col.width ? 'width:' + col.width : null,
|
|
onClick: function (ev) { onHeaderClick(col.field, ev.shiftKey); }
|
|
}, col.title || col.field, indicator);
|
|
titleRow.appendChild(th);
|
|
|
|
const td = util.h('td', { className: 'zddc-table__filter-cell' });
|
|
// Every column gets the same text-contains filter input, even
|
|
// enum columns — keeps the filter row visually uniform and
|
|
// doesn't constrain users to picking from the enum (a
|
|
// case-insensitive substring match works for both free-text
|
|
// and enum data).
|
|
const f = filterMap[col.field] || filters.defaultFilterFor(col);
|
|
const input = util.h('input', {
|
|
type: 'text',
|
|
className: 'zddc-table__filter-text',
|
|
placeholder: 'filter…',
|
|
'aria-label': 'Filter ' + (col.title || col.field),
|
|
value: typeof f.value === 'string' ? f.value : '',
|
|
onInput: function (ev) {
|
|
onFilterChange(col.field, { kind: 'contains', value: ev.target.value });
|
|
}
|
|
});
|
|
td.appendChild(input);
|
|
filterRow.appendChild(td);
|
|
}
|
|
|
|
theadEl.appendChild(titleRow);
|
|
theadEl.appendChild(filterRow);
|
|
}
|
|
|
|
function renderBody(tbodyEl, rows, columns) {
|
|
const util = app.modules.util;
|
|
const editor = app.modules.editor;
|
|
tbodyEl.innerHTML = '';
|
|
for (let i = 0; i < rows.length; i++) {
|
|
const row = rows[i];
|
|
const tr = util.h('tr', {
|
|
className: 'zddc-table__row' + (row.editable ? ' zddc-table__row--editable' : ' zddc-table__row--readonly'),
|
|
'data-url': row.url,
|
|
'data-editable': row.editable ? '1' : '0'
|
|
});
|
|
const rowId = editor ? editor.rowKey(row) : (row.url || '');
|
|
if (editor) {
|
|
editor.attachToRow(tr, rowId);
|
|
}
|
|
for (let c = 0; c < columns.length; c++) {
|
|
const col = columns[c];
|
|
// Editor's draft buffer overrides the row's stored value
|
|
// until Phase 3 commits it. Falls back to row.data when
|
|
// no draft is present.
|
|
const value = editor
|
|
? editor.effectiveCellValue(row, col)
|
|
: util.resolveField(row.data, col.field);
|
|
const text = util.formatCell(value, col.format);
|
|
const td = util.h('td', { className: 'zddc-table__cell' }, text);
|
|
if (editor) {
|
|
editor.attachToCell(td, i, c);
|
|
}
|
|
tr.appendChild(td);
|
|
}
|
|
tbodyEl.appendChild(tr);
|
|
}
|
|
}
|
|
|
|
function renderRowCount(el, displayed, total) {
|
|
if (!el) return;
|
|
if (displayed === total) {
|
|
el.textContent = total + (total === 1 ? ' row' : ' rows');
|
|
} else {
|
|
el.textContent = displayed + ' of ' + total + ' rows';
|
|
}
|
|
}
|
|
|
|
app.modules.render = {
|
|
header: renderHeader,
|
|
body: renderBody,
|
|
rowCount: renderRowCount
|
|
};
|
|
})(window.tablesApp);
|