The name filter (and the search-reveal path logic) used to force-expand every
folder on the way to a match, reshaping the tree the moment you typed. If you'd
collapsed everything except the one subtree you cared about, filtering blew the
rest open.
Now the filter only shows/hides rows IN PLACE: expansion is driven solely by the
user's folder.expanded. A collapsed folder that contains matches is still shown
(so you can open it) but stays collapsed — the filter never changes expand state.
Removed the autoOpen() force-expand and the `open` path-map it read.
Tests updated to the new contract: filter hides non-matches in place within
expanded folders, shows match-containing folders collapsed without revealing
their files, and leaves expand state untouched. Classifier suites 68 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a 4th paste column and use it to assign tracking numbers reliably. The old
auto-matcher keyed on "the tracking number appears in the filename" — backwards
for unorganized files that don't yet carry their number. The pasted current name
is an authoritative join key the user already has.
- parsePastedRows: FIXED schema by position — tracking_number · rev (status) ·
title · current name. Dropped the variant guessing (status-column merge,
single-filename split); a header row is still skipped, trailing columns may be
omitted. Rows carry currentName.
- proposeMatches: PRIMARY signal is now the current name (nameScore: exact on the
normalized, extension-dropped key = conf 1; token-coverage 0.6–0.95; clean
substring 0.7), FALLBACK is the old tracking-in-filename heuristic for rows
without a current name. Each proposal carries `auto` — true only for an exact
1:1 match (unique conf-1 for both its file and its row), the only kind safe to
assign unprompted. Duplicate names → not auto.
- Paste dialog: 4th preview column; on Add, exact 1:1 matches are auto-assigned
and a summary toast points to Match names for the rest. Match dialog pre-checks
only the exact matches, shows confidence + name/tracking#, flags the review-only
ones. New read-only "Current name" column in the worklist table.
Tests: fixed-schema parse, current-name exact(auto)+token match, ambiguous
duplicate (not auto), and the tracking fallback still holds. Suite 342 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The "From a list" scratch worklist still carried "mdl"/"existing" identifiers
from when it was the MDL/By-existing catalog — misleading now that it's a generic
scratch list and the real MDL is just the archive's mdl/ folder. Mechanical
rename across classify.js, target-tree.js, template.html, layout.css, and the
spec, leaving the genuine MDL concept (readMdlYamls, the mdl/ folder, inMdl,
migrateLegacyMdl) untouched:
- API/state: setMdlList→setWorklist, appendMdlRows→appendWorklist,
clearMdlList→clearWorklist, getMdlList→getWorklist, getMdlRow→getWorklistRow,
state.mdlList→state.worklist.
- DOM/UI: #mdlPanel→#worklistPanel, #mdlTree→#worklistTable,
#existingTab→#worklistTab, #loadMdlBtn→#loadWorklistBtn, the currentTab value
'existing'→'worklist'.
- internals: mdlTable→worklistGrid, mdlPlaced→worklistPlaced,
renderMdlInto→renderWorklist, ensureMdlTable→ensureWorklistGrid,
renderMdlPlaced→renderWorklistFiles, loadMdl→loadWorklist; CSS .mdl-rev__input
+ .fromlist-* → .worklist-*.
No behavior change; classify + classifier suites stay 66 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The full Playwright suite had 5 pre-existing failures (stale assertions for
since-reworked behavior) and the classifier carried dead code from removed flows.
Stale tests refreshed to current behavior:
- toast.spec (×3): toast.js now STACKS (sticky/dismissible) rather than showing
one at a time — assert stacking + the "Clear all" control, read the message
from .zddc-toast__msg (the toast also holds a × button), and dismiss via the ×
(clicking the body no longer dismisses, by design).
- browse.spec: "New folder/New file" moved from the toolbar into the context
menu — drop the #newFolderBtn/#newFileBtn assertions (Sort + Show-hidden stay).
- tokens.spec XSS guard: rewritten to the current apiActions modal flow
(#api-create-btn → .api-modal → #table-root) instead of the long-gone inline
#desc form. The escaping assertion now actually runs and confirms it holds.
Dead code removed:
- classifier .mdl-overlay* CSS (orphaned when the "MDL from archive" instantiate
flow moved to the tables tool).
- classify.js filesInNode() — defined + exported but called nowhere.
- "From a list" naming: refreshed a stale "catalog" comment and renamed the 3
remaining "By existing:" test titles.
Full suite now 340 passed / 0 failed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
When a user lacks permission, the app should (a) not let them do data entry it
will reject and (b) subtly say who can. General mechanism + the key gates.
Server — compute & expose "who can <verb> here":
- zddc.WhoCan(chain, verb) → Authority{Roles, People}: the acl.permissions
grantees holding the verb across the cascade (roles + their members) plus the
admins (who bypass). New whocan.go + whocan_test.go.
- AccessView gains path_who_can (profilehandler.go), populated only for verbs the
caller LACKS and only when they can read the path (mirrors .zddc readability),
so one cap.at() answers "can I?" and "if not, who?".
- writeForbiddenWho enriches the 403 body with who_can for the missing verb
(errors.go); authorizeAction uses it (fileapi.go) as the safety net for denials
that weren't pre-checked.
Shared — shared/cap.js:
- cap.whoCan(view, verb) + cap.denyHint(view, verb) → {text, title}, role-first
("Only the document controller can create here") with the people in the tooltip.
- handleForbidden appends the hint (from the 403 body, else the cached view), so
every tool that already routes 403s through it (form save, tables save, browse)
now explains who can — for free.
Key gates:
- Browse party-create (the reported bug): pre-check create authority on ssr/ and
the slot BEFORE opening the picker — if the user can do neither, show the hint
instead of the form; if only existing parties are usable, disable "+ New party"
with the who-can hint. The post-hoc 403 catch now names who can too.
- Tables +Add row disabled state shows the who-can hint.
Plus: subtle /_apps/{browse,archive,classifier}.html links in the landing footer.
Tests: Go WhoCan unit test (role/person split, admin bypass, dedupe); cap.spec.js
(denyHint role-first/people/fallback, whoCan, handleForbidden enrichment) — 5
green; Go handler+zddc+policy suites green. (Pre-existing stale browse toolbar
test browse.spec.js:274 unaffected.)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rework the "By existing" catalog into a "From a list" scratch worklist that can
be populated three ways and cleared without losing work.
Core model — retire the separate `mdl` assignment axis. Dropping a file on a row
now MATERIALIZES a real "By tracking number" placement (assignFromRow →
addTrackingPath + place(…,'tracking') + title override), reusing the typed-
filename path. Consequences:
- Clearing the list can't lose classifications (no assignment references a row);
dropped files show under By tracking number.
- The two name axes collapse into one (place/deriveTarget/fileCategory simplified).
- Workspace migration: load() materializes any legacy `mdlNodeId` into a tracking
placement BEFORE anything can prune, so saved workspaces keep their work.
- A tracking number's last segment is an ancestor and the revision is always the
leaf, so a blank-revision drop lands on a `pending` placeholder leaf; editing
the row's tracking number or revision re-stamps the row's files onto the new
leaf and prunes the emptied one.
UI:
- One editable Tracking number column (no per-field split) + editable Title — so
you can drop on an entry and bump e.g. the sequence for a new drawing.
- Source column (MDL / arch / pasted) with an amber "new"/"unverified" badge when
a pasted number matches nothing scanned — the typo catcher.
- Toolbar: Load… (now appends) · Paste rows… · ⚡ Match names · Clear list ·
Hide assigned. Tab renamed "From a list"; goal line + hint teach the scratch-pad.
- Paste dialog (Ctrl-V on the panel too) with a live parse preview; parsePastedRows
handles 3-col, a split status column, a pasted full filename, header + bad rows.
- Match names reviews proposeMatches (filename ⊇ a known tracking number) and
assigns the checked pairs.
Tests: materialize+clear, tracking-edit re-stamp + prune, legacy migration,
parsePastedRows, proposeMatches; 66 classify+classifier green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Two UI fixes:
- "By existing" catalog columns were far too wide. The seltable forced the
table to width:100% (auto-layout then stretches columns) and — in the
classifier's copy — the per-column filter <input>s had no styling, so each
fell back to its ~170px intrinsic width and dictated the column width. Set
the table to width:auto (cells are already nowrap → fit header/longest cell)
and style .seltable__colfilter to fill its column (min-width:2rem,
box-sizing:border-box) so the inputs never widen a column. Applied to both
the classifier copy and shared/seltable.css (same fix for the tables tool's
"Add from archive" table).
- The left Folder Tree rendered folders and files in raw scan order. Sort both
at render — case-insensitive, natural (so "Rev 2" precedes "Rev 10") — via a
non-mutating slice().sort() at each render point in tree.js.
Tests: a new spec asserts the natural/case-insensitive tree order; 62 classify
+ classifier green (108 across classify/classifier/tables/tables-mdl).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reshape the catalog from a button+overlay into a proper tab and let the user
choose which directories feed it.
- Tabs: the Catalog button becomes a third tab "By existing", grouped with "By
tracking number" (both assign a tracking number) and visually separated from
"By transmittal" (which assigns the path). A brief goal line above the tabs
states the workflow. The overlay #mdlPanel becomes a normal in-flow tab panel.
- Load: instead of auto-scanning a whole project, "Load…" opens a lazy,
multi-select (checkbox) directory tree (new classifier/js/dir-picker.js).
Ticking a directory includes its whole subtree; confirm resolves the topmost
ticked handles. Scope follows where the classifier is served: /_apps/… → all
accessible projects, under <project>/… → that one project, file:// → a picked
folder. The picker is handle-agnostic (HttpDirectoryHandle or native FS).
- Rows: every ticked directory is walked recursively into the union of existing
files (zddc.parseFilename) and MDL deliverables (mdl/*.yaml → inMdl + title),
deduped to one row per tracking number. The "Archive revs" (all) column
becomes a single informational "Latest rev" computed via zddc.compareRevisions.
Drop still assigns the tracking number only; the Revision cell stays blank.
- classify.js is unchanged — the mdl axis model and row shape are reused as-is
(Latest rev derives from the preserved archiveRevisions).
- Tests: the catalog test now asserts latest-rev; new unit tests cover
walkDirInto union/dedupe-to-latest, _latestRevOf draft/modifier ordering,
_detectScope routing, and the dir-picker topmost-ticked resolution. 61 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Instantiating deliverable yamls from existing archive files is an MDL-side
workflow (assigning files to deliverables stays here; registering tracking
numbers belongs with the MDL). It moved to the tables tool's project MDL
rollup in the prior commit, so remove the classifier copy:
- delete classifier/js/mdl-instantiate.js + its build entry
- remove the ⊞ MDL from archive header button + its app.js wiring
- drop the two mdl-instantiate unit tests (the equivalents now live in
tests/tables-mdl.spec.js)
The read-only Catalog button (MDL ∪ archive, drop-to-assign) is unaffected.
Classifier + classify suites: 58 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The MDL owns the workflow of registering deliverables; this is the
catch-up path for files that already exist in the archive but were never
listed. On the project MDL rollup (<project>/mdl/, addable:false), a new
"＋ From archive" toolbar button opens an overlay that walks the project
archive into the shared seltable (per-column autofilter + ctrl-shift
selection), dedupes the selection to one deliverable per tracking number,
and PUTs a deliverable .yaml into each originator's archive/<originator>/
mdl/. Identity fields are split positionally from the tracking number per
the project's own table columns (originator is folder-pinned, so omitted
from the body); the server composes/validates the filename. Existing
deliverables are skipped; created/skipped/failed are reported.
- tables/js/mdl-from-archive.js: walkArchive / dedupe / deliverableFromFile
/ instantiateOne + the overlay UI; setup() shows the button only on an
/mdl/ rollup over http, gated on archive create permission.
- shared/seltable.css: promoted seltable base styles + per-column filter
row + the overlay chrome (bundled into tables; classifier keeps its
inline copy).
- main.js wires setup(ctx); template.html adds the (hidden) button;
build.sh bundles ../shared/seltable.{js,css} + the new module.
- tests/tables-mdl.spec.js (new project): split/dedupe/walk/instantiate
against in-page mock FS handles; 7 green. tables suite still 47 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reframes the By-MDL tab as a "⊞ Catalog" button that opens an overlay over the
target pane (the left filetree stays the drag source). The catalog is the
de-duplicated union of everything the project knows about a tracking number:
its MDL deliverables AND its archive files, merged by tracking number, with an
informational "Archive revs" column (which revisions already exist) and an "MDL"
flag. Nothing is written or altered — the Revision column is classifier-local
and starts blank (never pre-filled from an old archive rev).
- Drag a source file onto a row → assigns the tracking number only (the mdl
axis); set the revision in the bulk-editable Revision column (ctrl-shift
select rows + ctrl-Enter). Per-file Title: MDL/file toggle + ✕ remove kept.
- Columns split the tracking number into the configured pattern fields, each with
its own autofilter (per-column, via the shared seltable). Default pattern is
now the 8-field ORIG-PHASE-PROJECT-AREA-DISC-TYPE-SEQ-SUFFIX.
- Server load merges every party's archive/<party>/mdl/*.yaml with a recursive
walk of the archive documents; local load reads a folder of deliverable yamls.
Test: catalog shows merged archive revisions; drop names a file (tracking only);
bulk revision feeds the derived name.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
