Commit graph

7 commits

Author SHA1 Message Date
36fe38b235 refactor(classifier): rename the misleading mdl* internals to worklist* (#8)
The "From a list" scratch worklist still carried "mdl"/"existing" identifiers
from when it was the MDL/By-existing catalog — misleading now that it's a generic
scratch list and the real MDL is just the archive's mdl/ folder. Mechanical
rename across classify.js, target-tree.js, template.html, layout.css, and the
spec, leaving the genuine MDL concept (readMdlYamls, the mdl/ folder, inMdl,
migrateLegacyMdl) untouched:

- API/state: setMdlList→setWorklist, appendMdlRows→appendWorklist,
  clearMdlList→clearWorklist, getMdlList→getWorklist, getMdlRow→getWorklistRow,
  state.mdlList→state.worklist.
- DOM/UI: #mdlPanel→#worklistPanel, #mdlTree→#worklistTable,
  #existingTab→#worklistTab, #loadMdlBtn→#loadWorklistBtn, the currentTab value
  'existing'→'worklist'.
- internals: mdlTable→worklistGrid, mdlPlaced→worklistPlaced,
  renderMdlInto→renderWorklist, ensureMdlTable→ensureWorklistGrid,
  renderMdlPlaced→renderWorklistFiles, loadMdl→loadWorklist; CSS .mdl-rev__input
  + .fromlist-* → .worklist-*.

No behavior change; classify + classifier suites stay 66 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 07:57:07 -05:00
51f5947716 refactor(classifier): dedupe seltable CSS + tidy From-a-list scratch edges
- #7 seltable CSS: the classifier carried its own copy of the base seltable
  rules (diverged from shared/seltable.css — a stale sticky offset + a dead
  .seltable__filter). Bundle shared/seltable.css and keep only the
  classifier-specific catalog bits (.seltable__extra, .mdl-rev__input,
  .fromlist-*, .src-badge, #mdlTree). One source of truth, shared with tables.
- #9 Clear list now confirms when it would strand files that still need a
  revision (on a "pending" leaf) — they stay assigned under By tracking number,
  but the row to finish them here is going away, so warn first.
- #10 serialize() strips the transient row→keys hint (`placed`) — it's rebuilt
  as drops happen and was needlessly bloating every workspace autosave.

(#8, renaming the internal mdl* identifiers to match "From a list", is left as
deliberate churn-avoidance — purely cosmetic, spans template/css/js/tests/DOM
ids, and the user-facing strings already read "From a list".)

Full suite 340 passed / 0 failed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 12:16:58 -05:00
921713d0a4 chore: clear tech debt — green the suite + delete dead code
The full Playwright suite had 5 pre-existing failures (stale assertions for
since-reworked behavior) and the classifier carried dead code from removed flows.

Stale tests refreshed to current behavior:
- toast.spec (×3): toast.js now STACKS (sticky/dismissible) rather than showing
  one at a time — assert stacking + the "Clear all" control, read the message
  from .zddc-toast__msg (the toast also holds a × button), and dismiss via the ×
  (clicking the body no longer dismisses, by design).
- browse.spec: "New folder/New file" moved from the toolbar into the context
  menu — drop the #newFolderBtn/#newFileBtn assertions (Sort + Show-hidden stay).
- tokens.spec XSS guard: rewritten to the current apiActions modal flow
  (#api-create-btn → .api-modal → #table-root) instead of the long-gone inline
  #desc form. The escaping assertion now actually runs and confirms it holds.

Dead code removed:
- classifier .mdl-overlay* CSS (orphaned when the "MDL from archive" instantiate
  flow moved to the tables tool).
- classify.js filesInNode() — defined + exported but called nowhere.
- "From a list" naming: refreshed a stale "catalog" comment and renamed the 3
  remaining "By existing:" test titles.

Full suite now 340 passed / 0 failed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 12:02:51 -05:00
f66b9c5d55 feat(classifier): "From a list" — a scratch worklist that materializes tracking placements
Rework the "By existing" catalog into a "From a list" scratch worklist that can
be populated three ways and cleared without losing work.

Core model — retire the separate `mdl` assignment axis. Dropping a file on a row
now MATERIALIZES a real "By tracking number" placement (assignFromRow →
addTrackingPath + place(…,'tracking') + title override), reusing the typed-
filename path. Consequences:
- Clearing the list can't lose classifications (no assignment references a row);
  dropped files show under By tracking number.
- The two name axes collapse into one (place/deriveTarget/fileCategory simplified).
- Workspace migration: load() materializes any legacy `mdlNodeId` into a tracking
  placement BEFORE anything can prune, so saved workspaces keep their work.
- A tracking number's last segment is an ancestor and the revision is always the
  leaf, so a blank-revision drop lands on a `pending` placeholder leaf; editing
  the row's tracking number or revision re-stamps the row's files onto the new
  leaf and prunes the emptied one.

UI:
- One editable Tracking number column (no per-field split) + editable Title — so
  you can drop on an entry and bump e.g. the sequence for a new drawing.
- Source column (MDL / arch / pasted) with an amber "new"/"unverified" badge when
  a pasted number matches nothing scanned — the typo catcher.
- Toolbar: Load… (now appends) · Paste rows… ·  Match names · Clear list ·
  Hide assigned. Tab renamed "From a list"; goal line + hint teach the scratch-pad.
- Paste dialog (Ctrl-V on the panel too) with a live parse preview; parsePastedRows
  handles 3-col, a split status column, a pasted full filename, header + bad rows.
- Match names reviews proposeMatches (filename ⊇ a known tracking number) and
  assigns the checked pairs.

Tests: materialize+clear, tracking-edit re-stamp + prune, legacy migration,
parsePastedRows, proposeMatches; 66 classify+classifier green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 10:48:26 -05:00
93ed0d361f feat(classifier): "By existing" tab + multi-select directory picker
Reshape the catalog from a button+overlay into a proper tab and let the user
choose which directories feed it.

- Tabs: the Catalog button becomes a third tab "By existing", grouped with "By
  tracking number" (both assign a tracking number) and visually separated from
  "By transmittal" (which assigns the path). A brief goal line above the tabs
  states the workflow. The overlay #mdlPanel becomes a normal in-flow tab panel.
- Load: instead of auto-scanning a whole project, "Load…" opens a lazy,
  multi-select (checkbox) directory tree (new classifier/js/dir-picker.js).
  Ticking a directory includes its whole subtree; confirm resolves the topmost
  ticked handles. Scope follows where the classifier is served: /_apps/… → all
  accessible projects, under <project>/… → that one project, file:// → a picked
  folder. The picker is handle-agnostic (HttpDirectoryHandle or native FS).
- Rows: every ticked directory is walked recursively into the union of existing
  files (zddc.parseFilename) and MDL deliverables (mdl/*.yaml → inMdl + title),
  deduped to one row per tracking number. The "Archive revs" (all) column
  becomes a single informational "Latest rev" computed via zddc.compareRevisions.
  Drop still assigns the tracking number only; the Revision cell stays blank.
- classify.js is unchanged — the mdl axis model and row shape are reused as-is
  (Latest rev derives from the preserved archiveRevisions).
- Tests: the catalog test now asserts latest-rev; new unit tests cover
  walkDirInto union/dedupe-to-latest, _latestRevOf draft/modifier ordering,
  _detectScope routing, and the dir-picker topmost-ticked resolution. 61 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-11 19:39:55 -05:00
d4d48cad4a feat(classifier): MDL becomes a read-only catalog (MDL ∪ archive) overlay
Reframes the By-MDL tab as a "⊞ Catalog" button that opens an overlay over the
target pane (the left filetree stays the drag source). The catalog is the
de-duplicated union of everything the project knows about a tracking number:
its MDL deliverables AND its archive files, merged by tracking number, with an
informational "Archive revs" column (which revisions already exist) and an "MDL"
flag. Nothing is written or altered — the Revision column is classifier-local
and starts blank (never pre-filled from an old archive rev).

- Drag a source file onto a row → assigns the tracking number only (the mdl
  axis); set the revision in the bulk-editable Revision column (ctrl-shift
  select rows + ctrl-Enter). Per-file Title: MDL/file toggle + ✕ remove kept.
- Columns split the tracking number into the configured pattern fields, each with
  its own autofilter (per-column, via the shared seltable). Default pattern is
  now the 8-field ORIG-PHASE-PROJECT-AREA-DISC-TYPE-SEQ-SUFFIX.
- Server load merges every party's archive/<party>/mdl/*.yaml with a recursive
  walk of the archive documents; local load reads a folder of deliverable yamls.

Test: catalog shows merged archive revisions; drop names a file (tracking only);
bulk revision feeds the derived name.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-11 14:58:31 -05:00
Me Here
2bc582fd9e ZDDC: document-control tools + zddc-server 2026-06-11 13:32:31 -05:00