Commit graph

18 commits

Author SHA1 Message Date
054cf2d79b feat(classifier): multi-select source files + drag to fill a contiguous block of rows
A contiguous run of drawings on the left commonly maps to a contiguous set of
rows on the right, so make that a single gesture.

- Left tree: ctrl/cmd-click toggles a source file into a multi-selection,
  shift-click ranges from the anchor, ctrl-shift-click adds a range (over the
  visible file order). Selected files get a highlight and drag together, in
  top-to-bottom order. A plain click still previews.
- By-tracking grid: dropping N dragged files onto a placeholder row fills the N
  consecutive placeholder rows from there (file[i] → row[i], Excel-style column
  fill). Drops are now handled at the grid-container level so the dragover shows
  a live indicator outlining EXACTLY the rows that will be updated
  (.tg-fill-target). Dropping over empty space / a file row still just adds the
  files as new rows. Fill walks the rows in DOM (display) order and looks each
  worklist row up by id from the model, so a re-render between binds can't
  disturb the loop.

Test: a 3-file drop on the first of three placeholders fills m1/m2/m3 in order
and consumes all three placeholders. 70 classify green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 09:57:57 -05:00
f82d6919b4 feat(classifier): one classify surface — By-tracking grid with Rename, transmittal with Copy
Collapse the two-mode tool (Classify & copy / Rename in place) into a single
surface. The top mode toggle and the standalone Rename spreadsheet are gone; the
By-tracking grid is now the one editable table, and the two operations are framed
as the two physical things you can do with a classified file:

- By tracking number → "Rename…": a tracking number + rev + title with no
  transmittal IS a rename, so this renames the name-complete grid files IN PLACE
  on disk (rename.js, lifted from the spreadsheet — HTTP move / FS copy+remove,
  resumable). Blocking red no-backup warning; a renamed file is now correctly
  named so it leaves the grid (classify.forgetFile).
- By transmittal → "Copy…": the existing resumable/verified archive copy, moved
  onto this tab; enabled once files are fully classified (tracking + transmittal).

"From a list" is folded into the By-tracking grid, not a separate tab. The grid
now holds two boring row kinds (one row ↔ 0-or-1 file):
- file rows (workset / placed), edited via setFileIdentity;
- placeholder rows = list rows with no file yet (Load…/Paste rows…/Match names),
  edited via the worklist setters; drop or match a file and it becomes a file row.
Dropping N files on a placeholder fans out over consecutive placeholders
(fillFromRow) — the start of the Excel-style block fill. New "⊕ Add filtered
files" pulls every file the left-tree filter shows into the grid. Source / Latest
rev fold in as optional (default-hidden) columns.

Chrome: removed the mode toggle + spreadsheet pane from the template; severed the
spreadsheet/sort/filter/resize/selection inits in app.js (modules stay bundled,
store still drives folder selection + reset); setMode() is now a no-arg enabler;
welcome tutorial rewritten to the single flow.

Tests: bootstrap via app.setMode() (no mode button); mode-switch test asserts the
single surface; worklist test drives placeholder rows in #trackingTree. 69
classify + 56 classifier/tables/cap green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 09:53:04 -05:00
1bb5d1ad97 feat(classifier): export filtered file list to TSV + direct path bind on paste-back
A round-trip workflow: export the file list, edit it in Excel, paste it back —
binding files by exact path or fuzzy name.

Export (left / folder tree, Classify mode):
- A "⬆ Export list" button in the Show toolbar copies the CURRENT filtered file
  set (name search + the Show toggles) to TSV — header `path<TAB>file`, files
  only, no folder rows. It honours every active filter but ignores expand/collapse
  (display-only), so files inside collapsed folders are included. `path` is the
  file's root-relative key; `file` is the bare filename. Clipboard copy, with a
  .tsv download fallback when the clipboard API is blocked (e.g. file://).
- Reuses the tree's computeVisible() so the export matches exactly what the
  filters show.

Paste-back (right / "Paste rows"): the Current name column now accepts either form
- Bare filename → today's behaviour: fuzzy name match / drop later.
- Full path (the exported `path`) → binds that EXACT file directly on paste:
  proposeMatches detects currentName === a file's key as a confidence-1 `via:'path'`
  match (the strongest signal), folded into the existing auto-assign pass. A path
  that matches nothing falls back to its basename for fuzzy matching.
- A pasted full path on a row with NO tracking number yet is still CLAIMED
  (recorded in row.bound); when a tracking/rev later lands, restampRow places the
  claimed file onto the new leaf. (User choice A.)

Tests: export TSV honours the filter + includes collapsed folders; a full-path
Current name binds the exact file (and leaves others untouched); a path with no
tracking is claimed then placed once tracking is filled. 69 classify green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 08:50:49 -05:00
e32258fa9f fix(classifier): move pane splitter handle off the folder-tree scrollbar
The tree-pane resize handle sat at right:0 inside the left pane with z-index:10,
so its 5px grab area + hover highlight landed directly on the folder tree's
vertical scrollbar — covering it and intercepting the pointer, so the user
couldn't grab the scrollbar near the splitter. Shift the handle to right:-6px so
it overhangs just past the 1px split border into the right pane, covering that
pane's edge padding instead. Drag math is clientX-delta based, so position is
purely visual + hit-area — resizing is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 08:36:19 -05:00
be5b3967ba feat(classifier): unify all tables on seltable — multi-sort + autofilter + resize
Every column table in the classifier now has the same three powers: multi-column
sort, per-column autofilters, and drag-resizable widths. Two of the three tables
were each missing one; the fix is to make the shared seltable the single engine.

- shared/seltable.js: add multi-column sort (click a header to sort; shift/ctrl-
  click ADDS a secondary key; asc→desc→off cycle; ▲/▼ + priority indicator) and
  self-contained drag-resizable columns (a .seltable__resizer on each title th —
  no dependency on the classifier-only resize.js, since the tables tool shares
  seltable). New opt-in opts.persistKey persists widths + sort to localStorage.
- By-tracking grid → seltable (target-tree.js): the bespoke merged-cell table is
  replaced by a seltable (status badge, original-name preview link, editable
  tracking/rev/title inputs, ✕). It inherits sort + autofilter + resize for free.
  The Columns ▾ chooser now rebuilds the seltable; widths + sort persist under the
  same prefs key. Grid is self-correcting — a column-set change rebuilds on render.
- Worklist (already seltable): gains sort + resize automatically; the derived
  Source column is marked non-sortable/non-filterable.
- The Rename-in-place spreadsheet already had all three (sort.js + filter.js +
  resize.js) — no change needed there.
- seltable.css: .seltable__resizer / .seltable__sortind / sortable-header cursor.
- tests: seltable multi-sort (header click, shift-add, indicators) + resize
  (drag widens + persists via persistKey); the grid's selectors move off the old
  .ttable--grid onto .seltable__table. 66 classify + 56 classifier/tables green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 08:09:35 -05:00
10474c549e ux(classifier): tighten Folder Tree row spacing
Folder rows kept 0.5rem padding from before the name+count were stacked, leaving
a lot of blank vertical space between items. Drop to 0.1rem vertical (file rows
are already this tight) and set a compact line-height.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-16 07:19:49 -05:00
2b32aced6d feat(classifier): By Tracking Number is now a flat editable grid (one row per file)
Replace the merged-cell positional table (one column per tracking-number segment,
hierarchy via shared ancestors, built by creating folders) with a plain editable
spreadsheet: one row per file, with the tracking number, the rev (status), and
the title as three separate editable columns. Columns are hideable + resizable.

The storage model is unchanged — a file's tracking identity is still its
placement in the tracking-folder tree. The grid is a flat presentation + inline-
edit layer over it; editing a cell re-materializes the placement via the existing
path (addTrackingPath → place(…,'tracking') → setTitleOverride), generalized to
per-field.

- classify.js: `trackingWorkset` (serialized) so a dropped file is a row before
  it has a number; `addToTrackingGrid`/`removeFromTrackingGrid`/`trackingGridKeys`
  (union with files that have a tracking placement — incl. ones named via "From a
  list"); `setFileIdentity(key, {tracking, rev, title})` re-files + prunes the old
  leaf; blank tracking = an unfilled row, blank rev = a PENDING_REV leaf.
- target-tree.js: `renderTrackingGrid` (Status badge · Original name preview ·
  Tracking number · Rev (status) · Title · ✕); drag onto the grid adds rows and
  auto-fills any file whose own name already parses as ZDDC; a "Columns ▾" chooser
  + drag-resize (resize.js, now parameterized) persisted to localStorage. The
  status badge validates the NAME only (the transmittal is a different tab).
  Removed the merged-cell machinery + per-node CRUD (+ Root folder, ✎/🗑, brace
  expansion) and the now-dead drop-on-node path.
- template/css: tracking toolbar → Columns chooser + hint; flat-grid + chooser CSS.

Tests: replaced the merged-cell/+Root-folder/drop-on-leaf/filename-edit tests with
grid tests (render, drop+auto-fill, per-cell re-file, filter, hide/persist,
preview link). Suite 342 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 16:51:39 -05:00
e58347d476 fix(classifier): By-tracking columns no longer reserve width for hover-only buttons
Each merged-cell column was sized to fit the per-node action buttons (+ ✎ 🗑),
even though they're invisible until you hover the cell. The buttons sat in flow
inside the sticky .tcell__inner. Float them absolutely over the right of the cell
instead (revealed on hover, pointer-events gated), so a column now sizes to its
value alone. Classifier suites 69 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 15:19:05 -05:00
2989e6e847 ux(classifier): stack the folder count below the folder name
The "direct+total folders/files" badge was right-aligned on the folder row;
move it under the name. The name + count now live in a vertical .folder-namebox
(flex column, flex:1), and the row aligns items to the top so the toggle/icon
sit on the name line with the count beneath. Dropped the count's right margin.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 10:09:46 -05:00
0847c7a844 feat(classifier): paste a "current name" column → match files by name
Add a 4th paste column and use it to assign tracking numbers reliably. The old
auto-matcher keyed on "the tracking number appears in the filename" — backwards
for unorganized files that don't yet carry their number. The pasted current name
is an authoritative join key the user already has.

- parsePastedRows: FIXED schema by position — tracking_number · rev (status) ·
  title · current name. Dropped the variant guessing (status-column merge,
  single-filename split); a header row is still skipped, trailing columns may be
  omitted. Rows carry currentName.
- proposeMatches: PRIMARY signal is now the current name (nameScore: exact on the
  normalized, extension-dropped key = conf 1; token-coverage 0.6–0.95; clean
  substring 0.7), FALLBACK is the old tracking-in-filename heuristic for rows
  without a current name. Each proposal carries `auto` — true only for an exact
  1:1 match (unique conf-1 for both its file and its row), the only kind safe to
  assign unprompted. Duplicate names → not auto.
- Paste dialog: 4th preview column; on Add, exact 1:1 matches are auto-assigned
  and a summary toast points to Match names for the rest. Match dialog pre-checks
  only the exact matches, shows confidence + name/tracking#, flags the review-only
  ones. New read-only "Current name" column in the worklist table.

Tests: fixed-schema parse, current-name exact(auto)+token match, ambiguous
duplicate (not auto), and the tracking fallback still holds. Suite 342 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 08:52:48 -05:00
36fe38b235 refactor(classifier): rename the misleading mdl* internals to worklist* (#8)
The "From a list" scratch worklist still carried "mdl"/"existing" identifiers
from when it was the MDL/By-existing catalog — misleading now that it's a generic
scratch list and the real MDL is just the archive's mdl/ folder. Mechanical
rename across classify.js, target-tree.js, template.html, layout.css, and the
spec, leaving the genuine MDL concept (readMdlYamls, the mdl/ folder, inMdl,
migrateLegacyMdl) untouched:

- API/state: setMdlList→setWorklist, appendMdlRows→appendWorklist,
  clearMdlList→clearWorklist, getMdlList→getWorklist, getMdlRow→getWorklistRow,
  state.mdlList→state.worklist.
- DOM/UI: #mdlPanel→#worklistPanel, #mdlTree→#worklistTable,
  #existingTab→#worklistTab, #loadMdlBtn→#loadWorklistBtn, the currentTab value
  'existing'→'worklist'.
- internals: mdlTable→worklistGrid, mdlPlaced→worklistPlaced,
  renderMdlInto→renderWorklist, ensureMdlTable→ensureWorklistGrid,
  renderMdlPlaced→renderWorklistFiles, loadMdl→loadWorklist; CSS .mdl-rev__input
  + .fromlist-* → .worklist-*.

No behavior change; classify + classifier suites stay 66 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-15 07:57:07 -05:00
51f5947716 refactor(classifier): dedupe seltable CSS + tidy From-a-list scratch edges
- #7 seltable CSS: the classifier carried its own copy of the base seltable
  rules (diverged from shared/seltable.css — a stale sticky offset + a dead
  .seltable__filter). Bundle shared/seltable.css and keep only the
  classifier-specific catalog bits (.seltable__extra, .mdl-rev__input,
  .fromlist-*, .src-badge, #mdlTree). One source of truth, shared with tables.
- #9 Clear list now confirms when it would strand files that still need a
  revision (on a "pending" leaf) — they stay assigned under By tracking number,
  but the row to finish them here is going away, so warn first.
- #10 serialize() strips the transient row→keys hint (`placed`) — it's rebuilt
  as drops happen and was needlessly bloating every workspace autosave.

(#8, renaming the internal mdl* identifiers to match "From a list", is left as
deliberate churn-avoidance — purely cosmetic, spans template/css/js/tests/DOM
ids, and the user-facing strings already read "From a list".)

Full suite 340 passed / 0 failed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 12:16:58 -05:00
921713d0a4 chore: clear tech debt — green the suite + delete dead code
The full Playwright suite had 5 pre-existing failures (stale assertions for
since-reworked behavior) and the classifier carried dead code from removed flows.

Stale tests refreshed to current behavior:
- toast.spec (×3): toast.js now STACKS (sticky/dismissible) rather than showing
  one at a time — assert stacking + the "Clear all" control, read the message
  from .zddc-toast__msg (the toast also holds a × button), and dismiss via the ×
  (clicking the body no longer dismisses, by design).
- browse.spec: "New folder/New file" moved from the toolbar into the context
  menu — drop the #newFolderBtn/#newFileBtn assertions (Sort + Show-hidden stay).
- tokens.spec XSS guard: rewritten to the current apiActions modal flow
  (#api-create-btn → .api-modal → #table-root) instead of the long-gone inline
  #desc form. The escaping assertion now actually runs and confirms it holds.

Dead code removed:
- classifier .mdl-overlay* CSS (orphaned when the "MDL from archive" instantiate
  flow moved to the tables tool).
- classify.js filesInNode() — defined + exported but called nowhere.
- "From a list" naming: refreshed a stale "catalog" comment and renamed the 3
  remaining "By existing:" test titles.

Full suite now 340 passed / 0 failed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-13 12:02:51 -05:00
f66b9c5d55 feat(classifier): "From a list" — a scratch worklist that materializes tracking placements
Rework the "By existing" catalog into a "From a list" scratch worklist that can
be populated three ways and cleared without losing work.

Core model — retire the separate `mdl` assignment axis. Dropping a file on a row
now MATERIALIZES a real "By tracking number" placement (assignFromRow →
addTrackingPath + place(…,'tracking') + title override), reusing the typed-
filename path. Consequences:
- Clearing the list can't lose classifications (no assignment references a row);
  dropped files show under By tracking number.
- The two name axes collapse into one (place/deriveTarget/fileCategory simplified).
- Workspace migration: load() materializes any legacy `mdlNodeId` into a tracking
  placement BEFORE anything can prune, so saved workspaces keep their work.
- A tracking number's last segment is an ancestor and the revision is always the
  leaf, so a blank-revision drop lands on a `pending` placeholder leaf; editing
  the row's tracking number or revision re-stamps the row's files onto the new
  leaf and prunes the emptied one.

UI:
- One editable Tracking number column (no per-field split) + editable Title — so
  you can drop on an entry and bump e.g. the sequence for a new drawing.
- Source column (MDL / arch / pasted) with an amber "new"/"unverified" badge when
  a pasted number matches nothing scanned — the typo catcher.
- Toolbar: Load… (now appends) · Paste rows… ·  Match names · Clear list ·
  Hide assigned. Tab renamed "From a list"; goal line + hint teach the scratch-pad.
- Paste dialog (Ctrl-V on the panel too) with a live parse preview; parsePastedRows
  handles 3-col, a split status column, a pasted full filename, header + bad rows.
- Match names reviews proposeMatches (filename ⊇ a known tracking number) and
  assigns the checked pairs.

Tests: materialize+clear, tracking-edit re-stamp + prune, legacy migration,
parsePastedRows, proposeMatches; 66 classify+classifier green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 10:48:26 -05:00
cfdf0f6db9 fix(classifier): fit-to-content catalog columns + sorted Folder Tree
Two UI fixes:

- "By existing" catalog columns were far too wide. The seltable forced the
  table to width:100% (auto-layout then stretches columns) and — in the
  classifier's copy — the per-column filter <input>s had no styling, so each
  fell back to its ~170px intrinsic width and dictated the column width. Set
  the table to width:auto (cells are already nowrap → fit header/longest cell)
  and style .seltable__colfilter to fill its column (min-width:2rem,
  box-sizing:border-box) so the inputs never widen a column. Applied to both
  the classifier copy and shared/seltable.css (same fix for the tables tool's
  "Add from archive" table).
- The left Folder Tree rendered folders and files in raw scan order. Sort both
  at render — case-insensitive, natural (so "Rev 2" precedes "Rev 10") — via a
  non-mutating slice().sort() at each render point in tree.js.

Tests: a new spec asserts the natural/case-insensitive tree order; 62 classify
+ classifier green (108 across classify/classifier/tables/tables-mdl).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-12 10:00:23 -05:00
93ed0d361f feat(classifier): "By existing" tab + multi-select directory picker
Reshape the catalog from a button+overlay into a proper tab and let the user
choose which directories feed it.

- Tabs: the Catalog button becomes a third tab "By existing", grouped with "By
  tracking number" (both assign a tracking number) and visually separated from
  "By transmittal" (which assigns the path). A brief goal line above the tabs
  states the workflow. The overlay #mdlPanel becomes a normal in-flow tab panel.
- Load: instead of auto-scanning a whole project, "Load…" opens a lazy,
  multi-select (checkbox) directory tree (new classifier/js/dir-picker.js).
  Ticking a directory includes its whole subtree; confirm resolves the topmost
  ticked handles. Scope follows where the classifier is served: /_apps/… → all
  accessible projects, under <project>/… → that one project, file:// → a picked
  folder. The picker is handle-agnostic (HttpDirectoryHandle or native FS).
- Rows: every ticked directory is walked recursively into the union of existing
  files (zddc.parseFilename) and MDL deliverables (mdl/*.yaml → inMdl + title),
  deduped to one row per tracking number. The "Archive revs" (all) column
  becomes a single informational "Latest rev" computed via zddc.compareRevisions.
  Drop still assigns the tracking number only; the Revision cell stays blank.
- classify.js is unchanged — the mdl axis model and row shape are reused as-is
  (Latest rev derives from the preserved archiveRevisions).
- Tests: the catalog test now asserts latest-rev; new unit tests cover
  walkDirInto union/dedupe-to-latest, _latestRevOf draft/modifier ordering,
  _detectScope routing, and the dir-picker topmost-ticked resolution. 61 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-11 19:39:55 -05:00
d4d48cad4a feat(classifier): MDL becomes a read-only catalog (MDL ∪ archive) overlay
Reframes the By-MDL tab as a "⊞ Catalog" button that opens an overlay over the
target pane (the left filetree stays the drag source). The catalog is the
de-duplicated union of everything the project knows about a tracking number:
its MDL deliverables AND its archive files, merged by tracking number, with an
informational "Archive revs" column (which revisions already exist) and an "MDL"
flag. Nothing is written or altered — the Revision column is classifier-local
and starts blank (never pre-filled from an old archive rev).

- Drag a source file onto a row → assigns the tracking number only (the mdl
  axis); set the revision in the bulk-editable Revision column (ctrl-shift
  select rows + ctrl-Enter). Per-file Title: MDL/file toggle + ✕ remove kept.
- Columns split the tracking number into the configured pattern fields, each with
  its own autofilter (per-column, via the shared seltable). Default pattern is
  now the 8-field ORIG-PHASE-PROJECT-AREA-DISC-TYPE-SEQ-SUFFIX.
- Server load merges every party's archive/<party>/mdl/*.yaml with a recursive
  walk of the archive documents; local load reads a folder of deliverable yamls.

Test: catalog shows merged archive revisions; drop names a file (tracking only);
bulk revision feeds the derived name.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-11 14:58:31 -05:00
Me Here
2bc582fd9e ZDDC: document-control tools + zddc-server 2026-06-11 13:32:31 -05:00